fix(logservice): close store on initialization failure#25774
Merged
mergify[bot] merged 3 commits intoJul 16, 2026
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
volgariver6
approved these changes
Jul 15, 2026
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 3 hours 4 minutes 7 seconds in the queue, including 1 hour 37 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #25740
What this PR does / why we need it:
NewServicecreates a live log store before loading local metadata and restoring persisted replicas. If either initialization step returned an error, the constructor returned without closing the store. The orphaned Dragonboat NodeHost kept its gossip/Raft listeners, TanDB handles, directory lock, and truncation worker alive, so an in-process retry with the same configuration failed with an address conflict.This change closes the store on both error paths while preserving the original initialization error. The successful startup path, on-disk metadata, and RPC behavior are unchanged.
The regression tests exercise both sides of the failure window:
dragonboat.ErrShardAlreadyExistafter one persisted replica has already been restored.Each test retries construction with the same UUID, data directory, and network addresses, proving that the NodeHost, workers, listeners, and storage handles were released.
Validation (with the standard MatrixOne CGo environment):
go test -v -count=1 -timeout 120s -run 'TestNewServiceClosesStoreOn(Metadata|ReplicaStart)Failure$' ./pkg/logservicego test -race -count=1 -timeout 180s -run 'TestNewServiceClosesStoreOn(Metadata|ReplicaStart)Failure$' ./pkg/logservicego test -v -count=1 -timeout 300s ./pkg/logservicego build ./pkg/logservicego vet ./pkg/logservice